Repository navigation
fix: send command lines one per prompt in non-interactive mode - #37
Merged
Merged
Conversation
--command and stdin mode queued the PS1 change, the command and the final exit in the pty all at once. The shell reads one line at a time, so the exit sat in the tty input queue while the command ran. Anything reading the tty swallowed it: sudo with use_pty relays all pending input to the pty it runs the command in, and a password prompt reads it as the password. Bash never got the exit and polysh waited forever, while a command like hostname -f that leaves the tty alone worked by luck. Only replace the prompt up front and let its callback feed the next command line each time the shell asks for input, then exit once nothing is left, as the --prompt branch already does. PS2 gets the same trigger so that if/fi, heredocs and trailing backslashes ask for their next line the same way.
Contributor
Author
|
Example where this was stuck before: |
brainexe
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--command and stdin mode queued the PS1 change, the command and the final exit in the pty all at once. The shell reads one line at a time, so the exit sat in the tty input queue while the command ran. Anything reading the tty swallowed it: sudo with use_pty relays all pending input to the pty it runs the command in, and a password prompt reads it as the password. Bash never got the exit and polysh waited forever, while a command like hostname -f that leaves the tty alone worked by luck.
Only replace the prompt up front and let its callback feed the next command line each time the shell asks for input, then exit once nothing is left, as the --prompt branch already does. PS2 gets the same trigger so that if/fi, heredocs and trailing backslashes ask for their next line the same way.