Repository navigation
Fix color resetting on iTerm on macOS. - #38
Merged
Merged
Conversation
Use SGR reset after colored hostname prefix. Terminal.pp treats "\033[1;m" as a reset, but iTerm2 treats it as "bold" only. This causes output to have the same color as the hostname.
kofrezo
self-requested a review
October 10, 2026 08:41
Contributor
|
That looks plausible to me also without AI. I will review and if valid merge it on Monday - thanks for your contribution |
kofrezo
approved these changes
Oct 12, 2026
kofrezo
pushed a commit
that referenced
this pull request
Oct 12, 2026
Use SGR reset after colored hostname prefix. Terminal.pp treats "\033[1;m" as a reset, but iTerm2 treats it as "bold" only. This causes output to have the same color as the hostname.
Contributor
|
Thanks! Released as 1.0.8 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SGR reset after colored hostname prefix. Without this, on macOS iTerm, output has the same color as the hostname, although Terminal is fine.
The fix was suggested by Claude, and I reviewed and tested it.