Skip to content

Fix color resetting on iTerm on macOS. - #38

Merged
kofrezo merged 1 commit into
innogames:masterfrom
ryanlovett:fix-color-reset
Oct 12, 2026
Merged

kofrezo merged 1 commit into
innogames:masterfrom
ryanlovett:fix-color-reset

Conversation

@ryanlovett

Copy link
Copy Markdown
Contributor

Use SGR reset after colored hostname prefix. Without this, on macOS iTerm, output has the same color as the hostname, although Terminal is fine.

The fix was suggested by Claude, and I reviewed and tested it.

Use SGR reset after colored hostname prefix. Terminal.pp treats "\033[1;m" as a reset, but iTerm2 treats it as "bold" only. This causes output to have the same color as the hostname.
@kofrezo
kofrezo self-requested a review October 10, 2026 08:41
@kofrezo

kofrezo commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

That looks plausible to me also without AI.

I will review and if valid merge it on Monday - thanks for your contribution

@kofrezo
kofrezo merged commit 6f3ce81 into innogames:master Oct 12, 2026
8 checks passed
kofrezo pushed a commit that referenced this pull request Oct 12, 2026
Use SGR reset after colored hostname prefix. Terminal.pp treats "\033[1;m"
as a reset, but iTerm2 treats it as "bold" only. This causes output to have
the same color as the hostname.
@kofrezo

kofrezo commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Thanks! Released as 1.0.8

@kofrezo kofrezo added the bug Something isn't working label Oct 12, 2026
@ryanlovett

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants