feat: update frontend scrumlr api - #6443
Conversation
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
f730cb1 to
b0c34b3
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
b0c34b3 to
cba6546
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
cba6546 to
b15589d
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
65083ba to
f6ea62f
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
| * | ||
| * @returns imported board | ||
| */ | ||
| importBoard: async (boardJson: BoardImportData): Promise<ImportBoardResponse> => { |
There was a problem hiding this comment.
The BoardImportData contains more data (participants) then the backend consumes. Still works but that is a drift of, we should fix.
There was a problem hiding this comment.
I think there a re a few drifts between the types in the frontend and the types in the backend that we should fix. But those fixes may have some other consequences.
|
|
||
| export const BoardAPI = { | ||
| /** | ||
| * Get all boards |
There was a problem hiding this comment.
should specify: Get all boards for a given user
| /** | ||
| * Get all boards | ||
| */ | ||
| getBoards: async () => { |
There was a problem hiding this comment.
has no return type given, is that intentional?
There was a problem hiding this comment.
Yes, this was intentional, because the return type from the API is []BoardOverview which is not implemented in the frontend.
| const url = buildUrl(`/boards/${boardId}/columns`); | ||
| try { | ||
| const response = await fetch(url, { | ||
| method: "POSt", |
| * @param boardId the board id | ||
| * @param reactionId the reaction id | ||
| * | ||
| * @returnsthe requested reaction |
041d699 to
6f8f920
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
4aa9dbf to
b24cd49
Compare
3cdfbae to
60f5d7a
Compare
|
The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
Description
For the upcoming event refactoring we need the complete api from the backend present in the frontend. This MR adds the missing requests to the frontend api. It also adds types to the requests where they were missing.
Changelog
Checklist
(Optional) Visual Changes