Skip to content

feat: update frontend scrumlr api - #6443

Open
Planlos5000 wants to merge 4 commits into
mainfrom
feat/fs/frontend_scrumlr_api
Open

feat: update frontend scrumlr api#6443
Planlos5000 wants to merge 4 commits into
mainfrom
feat/fs/frontend_scrumlr_api

Conversation

@Planlos5000

@Planlos5000 Planlos5000 commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

For the upcoming event refactoring we need the complete api from the backend present in the frontend. This MR adds the missing requests to the frontend api. It also adds types to the requests where they were missing.

Changelog

  • Add missing requests
  • Add types to request methods
  • Add url builder function
  • Add tests for url builder function
  • Update swagger page

Checklist

  • I have performed a self-review of my own code
  • I have written and understand every part of this contribution myself - if AI tools were used, I have thoroughly reviewed and verified all changes
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@Planlos5000 Planlos5000 added Review Needed This pull request is ready for review feat This pull request or issue adds a new feature Frontend At least some of this PR changes stuff in the frontend code labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-167d6cd

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-167d6cd

@Planlos5000
Planlos5000 marked this pull request as draft August 4, 2026 08:01
@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch from f730cb1 to b0c34b3 Compare August 4, 2026 11:19
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-dde53bd

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-dde53bd

@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch from b0c34b3 to cba6546 Compare August 4, 2026 14:20
@Planlos5000
Planlos5000 marked this pull request as ready for review August 4, 2026 14:22
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-cf70893

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-cf70893

@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch from cba6546 to b15589d Compare August 4, 2026 14:35
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-ab5eef6

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-ab5eef6

@Planlos5000 Planlos5000 self-assigned this Aug 4, 2026
@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch 2 times, most recently from 65083ba to f6ea62f Compare August 6, 2026 11:08
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-0109d0b

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-0109d0b

@Planlos5000 Planlos5000 linked an issue Aug 6, 2026 that may be closed by this pull request
Comment thread src/api/board.ts
*
* @returns imported board
*/
importBoard: async (boardJson: BoardImportData): Promise<ImportBoardResponse> => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BoardImportData contains more data (participants) then the backend consumes. Still works but that is a drift of, we should fix.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there a re a few drifts between the types in the frontend and the types in the backend that we should fix. But those fixes may have some other consequences.

Comment thread src/api/board.ts Outdated

export const BoardAPI = {
/**
* Get all boards

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should specify: Get all boards for a given user

Comment thread src/api/board.ts Outdated
/**
* Get all boards
*/
getBoards: async () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has no return type given, is that intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was intentional, because the return type from the API is []BoardOverview which is not implemented in the frontend.

Comment thread src/api/column.ts Outdated
const url = buildUrl(`/boards/${boardId}/columns`);
try {
const response = await fetch(url, {
method: "POSt",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big T :)

Comment thread src/api/reaction.ts Outdated
* @param boardId the board id
* @param reactionId the reaction id
*
* @returnsthe requested reaction

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space missing :)

@jmoehler jmoehler added Changes Requested Changes requested by the reviewer and removed Review Needed This pull request is ready for review labels Aug 6, 2026
@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch 2 times, most recently from 041d699 to 6f8f920 Compare August 7, 2026 06:11
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-c9a3697

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-c9a3697

@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch 3 times, most recently from 4aa9dbf to b24cd49 Compare August 13, 2026 06:28
@Planlos5000
Planlos5000 force-pushed the feat/fs/frontend_scrumlr_api branch from 3cdfbae to 60f5d7a Compare August 14, 2026 12:40
@github-actions

Copy link
Copy Markdown

The deployment to the dev cluster was successful. You can find the deployment here: https://6443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-a85ff4c

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-a85ff4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requested Changes requested by the reviewer feat This pull request or issue adds a new feature Frontend At least some of this PR changes stuff in the frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement scrumlr API for frontend

2 participants