fix: avoid avatar update when opening profile - #6490
Open
almacbe wants to merge 1 commit into
Open
Conversation
almacbe
marked this pull request as ready for review
August 13, 2026 07:12
This was referenced Aug 13, 2026
Schwehn42
reviewed
Aug 14, 2026
| const migratedAvatar = {...oldAvatar, backgroundColor: completeAvatar.backgroundColor}; | ||
| expect(API.editUser).toHaveBeenCalledWith({...auth, avatar: migratedAvatar}); | ||
| expect(store.getState().auth.user?.avatar).toEqual(migratedAvatar); | ||
| expect(API.editUser).toHaveBeenCalledTimes(1); |
Member
There was a problem hiding this comment.
is the duplicate toHaveBeenCalled check necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5577
AvatarSettingstreated its initial effect as a user change and persisted the current avatar whenever the profile opened. It now dispatcheseditSelfonly when the local avatar is semantically different from the persisted avatar.This keeps the intentional migration for older avatars without
backgroundColor, because the completed avatar still differs from the stored value and is persisted once. Regression tests cover initial mounting, real and duplicate shuffle results, optimistic updates, legacy avatars, and missing avatars.Changelog
API.editUserboundary.Checklist
(Optional) Visual Changes
None. This change does not alter the UI.