[sumbad]

No description provided.

[greptile-apps]

Confidence Score: 0/5

[Medium impact] The changes affect table editing and note loading across desktop and touch users.

Fix the cut failure path, merged-cell edits, and cross-table dragging before merging.

Findings

1.  Cut deletes before copying succeeds ▶
2.  Copied rows gain extra columns ▶
3.  Column fills replace merged cells ▶
4.  Paste skips copied cells ▶
5.  Drag crosses table boundaries ▶

Summary

This PR adds table clipboard buttons, row and column duplication, and desktop long-press selection. It also repairs stored cell colors and removes the old selection circle.

• Table users can copy, cut, and paste cells with table-aware results.
• Rows and columns can be duplicated beside the originals.
• Desktop and touch users select table cells without a corner handle.
• Table cells keep color attributes safe when pasted and read.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Table clipboard action] --> B{Copy, cut, or paste?}
  B -->|Copy| C[Write system clipboard]
  B -->|Cut| D[Start clipboard write]
  D --> E[Delete rows or clear cells]
  B -->|Paste| F{Cell selection?}
  F -->|Yes| G[Replace selected cell contents]
  F -->|No| H{Copied shape}
  H -->|One cell| I[Replace caret cell contents]
  H -->|One column| J[Insert and fill column]
  H -->|Other grid| K[Insert rows]

Loading

_{Reviews (1) · Last reviewed commit: "docs(changelog): unreleased — table clip..." · Reviewed by Greptile}

[sumbad]

Thanks for the careful review — all five findings addressed in 19ac63b, one turned out to be a false positive in its original framing:

1. Cut deletes before copying succeeds — fixed. Both cut paths (the Mod-X handler and the toolbar button) now dispatch the removal only after the clipboard write confirms (copyToSystemClipboard reports success). A denied clipboard leaves the content intact. Regression test added: a denied clipboard leaves the content intact.

2. Copied rows gain extra columns — fixed, and the reported desync was real: the clone carried a second merged cell into a column already covered by the extended merge. Columns covered by an extended merge now get no cell in the inserted copies (mirroring addRow). A TableMap shape assertion (width/height consistency) pins it in commands.duplicate.test.ts.

3. Column fills replace merged cells — fixed. insertColumnAfterCaret now skips fill slots covered by a rowspan from above — the same guard duplicateColumn already had.

4. Paste skips copied cells — fixed. The source cursor advances by one physical cell per placement; a colspan on a source node no longer skips its neighbours. This matters for internal drag&drop, where spans survive — DOM-clipboard pastes always parse spans as 1.

5. Drag crosses table boundaries — fixed. The desktop long-press extension ignores cells from other tables: the head must belong to the anchor's table, so the rectangle cannot cross a table boundary. (The mobile pointer path was already bounded by domCellAtPoint(cellTable(anchorDom), …).)

Verified locally: 678 unit tests green — new tests for findings 1, 2 and 4 — and the full e2e suite 48/48.