Repository navigation
refactor: extract extensible shared smoothing engine - #2452
Draft
changwangss wants to merge 3 commits into
Draft
changwangss wants to merge 3 commits into
changwangss wants to merge 3 commits into
Conversation
changwangss
force-pushed
the
refactor/shared-smoothing
branch
from
October 8, 2026 14:05
aac0d02 to
8e5e924
Compare
Signed-off-by: changwangss <chang1.wang@intel.com>
changwangss
force-pushed
the
refactor/shared-smoothing
branch
from
October 20, 2026 07:30
8e5e924 to
7d58d64
Compare
Signed-off-by: changwangss <chang1.wang@intel.com>
Signed-off-by: changwangss <chang1.wang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWQ and SVDQuant maintain separate smoothing workflows. Extract an algorithm-independent
SmoothEngine,SmoothGroup, and structuralSmoothStrategyinterface, and route both algorithms through the shared engine. New algorithms supply preparation, candidates, scoring, application, and cleanup without adding algorithm branches to the engine.Preserve AWQ's activation/weight means, ratio/duo grid, QDQ loss, folding, and clipping synchronization; preserve SVDQuant's absmax statistics, Alpha/Beta grid, deployed-scale precision, and low-rank-aware scoring. Keep smoothing optional for SVDQuant and retain its search-all-groups-before-installation order. Existing configuration and SVDQuant smooth imports remain available.
Both algorithms now keep the first exact tie and share numerical-invalid candidate handling, logging, trial-state restoration, and cleanup. Execution errors, including OOM, propagate. AWQ retains its no-valid-candidate skip fallback; SVDQuant retains its error behavior. Joint AWQ + SVDQuant execution and broader model support remain follow-up work.
Type of Change
Refactor
Related Issues
Closes #2451
Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1and--noconftestto isolate self-contained tests; this is not a full repository test run.Checklist Before Submitting