Repository navigation
enhance model_free functionality with strict parameter validation - #2520
Merged
Merged
Conversation
Signed-off-by: Xin He <xin3.he@intel.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved validation bypass, routing, and documentation issues must be addressed before approval.
1 open issue
What changed in this PR
Enhances explicit model_free=True validation to reject unsupported parameters and export formats instead of silently falling back.
Changes:
- Adds strict runtime and algorithm-parameter validation.
- Rejects unsupported model-free export formats.
- Expands validation and routing tests.
| File | Summary |
|---|---|
test/unit/test_cpu/utils/test_model_free_utils.py |
Tests static quantization rejection; routing validation remains unresolved. |
test/unit/test_cpu/quantization/test_model_free.py |
Adds coverage for invalid parameters and export formats. |
auto_round/compressors/model_free.py |
Updates model-free fallback behavior; public argument documentation needs correction. |
auto_round/autoround.py |
Adds strict validation, with a special disable_opt_rtn path that can bypass it. |
Review effort: Lite
This comment has been minimized.
This comment has been minimized.
…el_free mode Signed-off-by: Xin He <xin3.he@intel.com>
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--model_free should not automatically routes to regular path if some arguments are not supported, raise error instead.
.
Type of Change
Enhancement
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.