Repository navigation
fix(cli): next-step hints name the dokimi command; drop dead cmd_report - #252
Merged
Merged
Conversation
- personas discover/approve and baseline list/compare printed `python cli.py ...`; they now print `dokimi ...`, the console script. - The `arms run` example in the baseline-only model comparison report lacked the required --product and --questions and ended in a `[other parameters]` placeholder; it now parses as written. - cmd_report (commands/report.py) was never registered with a parser and read args no parser defines; removed with the import only it used. - tests/test_printed_hints_parse.py: every hint captured from its printing code names `dokimi` and parses with parse_args. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
requested review from
antonwolfy,
jharlow-intel,
vchamarthi and
xaleryb
as code owners
October 27, 2026 05:42
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 92.69% 92.75% +0.05%
==========================================
Files 256 256
Lines 32421 32414 -7
Branches 5422 5421 -1
==========================================
+ Hits 30054 30066 +12
+ Misses 1579 1562 -17
+ Partials 788 786 -2
🚀 New features to boost your workflow:
|
antonwolfy
approved these changes
Oct 27, 2026
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The four hints and the baseline-only arms run example now name the dokimi console script, and the example parses. Removing cmd_report is safe.
What I ran, on Linux at 1984856:
make ci-local: 26 passed, 2 failed, 7 skipped. The two failures are the gitleaks download (the proxy returned 504) and the commit scan that needs it, not this PR. Run by hand, gitleaks reports no leaks in the PR's commit.- 9,036 tests passed, 3 skipped. Changed-line coverage is 100% (4 lines).
- Mutation run on the new test file, 16 mutants, 13 killed. Killed: each of the 5 sites reverted to
python cli.py, a subcommand typo,--productdropped from thearms runexample,[other parameters]restored, a wrong flag. The 3 survivors are abbreviated flags (--fil,--persona) and dropping the optional--productfrombaseline save; the hint still works when copied. - With the base versions of
baseline.py,personas.pyandmodel_compare.py, all 5 new tests fail.
Checked, no issues
cmd_report: no caller, registration, string dispatch or entry point refers to it.write_run_reportandwrite_compare_reportare imported fromdokimi.report.markdown_reportby their other users, not viacommands/report.py. Ruff passes.arms runexample: parsed withparse_args; it givesproduct=oneTBB,questions=questions/oneTBB.json,judge=True.- Changelog fragment: present, one
### Fixedsection, in the repo's format.
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item A3 of #94 §5 (hygiene), stage A. Refs #94.
The four hints already parsed with
build_parser(); only the program name was stale, so flags are unchanged.The
arms runexample did not parse (required--product/--questionsmissing,[other parameters]placeholder), so it gets concrete values.The golden
tests/fixtures/model_compare_sections.jsonis re-recorded; the diff is the four hint entries.Numbers do not change.
Evidence
Merge Danger
Door: two-way. Text-only change in printed hints and one unregistered function. Revert restores the old strings.
Blast radius: CLI output text (four hints, one report paragraph). No exit codes, flags, or artifact fields change.
cmd_reporthad no caller, so removing it changes nothing reachable from the command line.Anyone who copies an old hint from a log into a shell gets
python cli.py …, which works only inside a source checkout. After this PR the hint prints the installeddokimicommand.Changelog fragment:
changelog.d/20261026_130000_napetrov_cli-stale-hints.md(Fixed).🤖 Generated with Claude Code