Repository navigation
[SYCL] Add diagnostic to work group scoped destructors. - #23581
Merged
Merged
Conversation
Non-trivial destructors are not currently supported in work group scopes. Depending on the backend, they either fail to link, are silently dropped, or cause other undefined behaviour. This change adds a warning message so users are made aware of this issue. Added a regression test to cover this new warning. Signed-off-by: Delisle, Thierry <thierry.delisle@intel.com>
Contributor
Author
|
This PR is a result of #23461 |
tahonermann
requested changes
Oct 22, 2026
tahonermann
left a comment
tahonermann
left a comment
Contributor
There was a problem hiding this comment.
Thanks @inteltdelisle, this looks pretty good to me. I requested a minor change to the diagnostic text and added a request for an additional note, if it isn't too difficult, to note where a capture occurs.
Signed-off-by: Delisle, Thierry <thierry.delisle@intel.com>
tahonermann
approved these changes
Oct 23, 2026
tahonermann
left a comment
tahonermann
left a comment
Contributor
There was a problem hiding this comment.
Thanks @inteltdelisle, this looks good to me. I agree about issuing that diagnostic note only for implicit captures.
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-trivial destructors are not currently supported in work group scopes. Depending on the backend, they either fail to link, are silently dropped, or cause other undefined behaviour. This change adds a warning message so users are made aware of this issue.
Added a regression test to cover this new warning.