Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
What changed in this PR
Adds a new SYCL E2E test to validate native graph capture/replay behavior for cooperative kernels using root-group synchronization and forward-progress guarantees on supported Intel GPUs.
Changes:
- Introduces a native-recording graph test that replays a cooperative “rotate” kernel multiple times and validates results.
- Covers two synchronization strategies:
use_root_syncroot-group barrier and a custom device-wide barrier using an atomic counter + concurrent forward progress.
| File | Description |
|---|---|
| sycl/test-e2e/Graph/RecordReplay/NativeRecording/concurrent_root_group.cpp | New E2E test exercising native graph recording/replay for cooperative kernels with root-group synchronization. |
Review effort: Lite
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mmichel11
force-pushed
the
agent/cooperative-kernels
branch
from
October 23, 2026 15:30
d63b5e3 to
a3dcb48
Compare
mmichel11
commented
Oct 23, 2026
| @@ -0,0 +1,138 @@ | |||
| // REQUIRES: level_zero_v2_adapter && (arch-intel_gpu_bmg_g21 || arch-intel_gpu_bmg_g31 || arch-intel_gpu_cri) | |||
| // REQUIRES-INTEL-DRIVER: lin: 40105 | |||
Contributor
Author
There was a problem hiding this comment.
There is a NEO bug that causes a feature not supported error return during graph instantiation with earlier versions.
mmichel11
marked this pull request as ready for review
October 23, 2026 15:31
Copilot stopped reviewing on behalf of
mmichel11 due to an error
October 23, 2026 16:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests native graph capture of cooperative kernels through the following SYCL extensions: