Repository navigation
Conversation
Contributor
Author
|
Unrelated CI error. |
KFilipek
force-pushed
the
ur-cmake-fixes
branch
from
October 26, 2026 10:51
a2cc6f0 to
2d5129d
Compare
Since the move to lit these tests passed the undefined TEST_SOURCES, so the binaries contained no tests and always passed. All 17 tests pass now.
CI only ran the adapter-specific and conformance suites, so the loader tests, including the adapter registry tests, never ran in CI.
urLoaderTearDown released the UMF reference on every successful call, not only when the last one deleted the context, so it also dropped UMF's own reference. UMF was then re-initialized repeatedly, overflowing its CTL node table after ~100 cycles and crashing loader_lifetime.test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
KFilipek
force-pushed
the
ur-cmake-fixes
branch
from
October 26, 2026 13:29
2d5129d to
e85136a
Compare
sarnex
approved these changes
Oct 26, 2026
sarnex
left a comment
sarnex
left a comment
Contributor
There was a problem hiding this comment.
devops changes lgtm, did not review python or ur code
ldorau
approved these changes
Oct 27, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
I've corrected it. |
ldorau
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST_SOURCES, so the binaries had no tests and always passed. They now build from their sources (17 tests, all pass).Test loaderstep inur-build-hw.ymlrunscheck-unified-runtime-loader.loader_lifetime.test. With static UMF,Inittakes oneumfInit()reference (it runs once), buturLoaderTearDowncalledumfTearDown()on every successful call. This dropped UMF's own reference, so UMF was re-initialized over and over and its CTL node table overflowed after about 100 cycles. Behavior change:umfTearDown()now runs only from the lasturLoaderTearDown, the one that deletes the context, and only ifumfInit()succeeded. Return values are unchanged.