Repository navigation
[SYCL][E2E] Use %cxx_std_optionc++20 instead of -std=c++20 - #23611
Merged
Merged
Conversation
uditagarwal97
requested review from
cperkinsintel and
dm-vodopyanov
and
a balanced review from Copilot
October 23, 2026 17:19
Contributor
Author
|
@mieshkiwrk fyi |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The one-line change uses the existing compiler-specific substitution without changing test behavior.
No open issues 🎉
What changed in this PR
This PR fixes the SYCL tracing end-to-end test’s C++20 compiler option so it works with both clang-cl and clang++.
Changes:
- Replaces
-std=c++20with the compiler-aware%cxx_std_optionc++20substitution. - Leaves test logic and expected tracing output unchanged.
| File | Description |
|---|---|
sycl/test-e2e/Tracing/code_location_kernel_obj_sequence.cpp |
Uses the portable C++20 option in the test build command. |
Review effort: Balanced
againull
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is failing with
clang-clwith the following error: