Repository navigation
Conversation
mdtoguchi
reviewed
Oct 23, 2026
|
|
||
| // RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -emit-llvm-bc -o %t.bc | ||
| // RUN: %clang_cc1 %s -triple spirv64-intel -fopenmp-is-target-device -emit-obj -o %t.device.o | ||
| // RUN: llvm-offload-binary -o %t.bundle "--image=file=%t.device.o,triple=spirv64-intel,arch=generic,kind=openmp,compile-opts=-cl-opt-disable" |
Contributor
There was a problem hiding this comment.
Should also test link-opts
mdtoguchi
reviewed
Oct 23, 2026
| void __tgt_register_lib(void *) {} | ||
| void __tgt_unregister_lib(void *) {} | ||
| int atexit(void (*)(void)) { return 0; } | ||
| } |
Contributor
There was a problem hiding this comment.
The clang-linker-wrapper call doesn't look to be doing any real linking, so these additional funcs aren't needed.
mdtoguchi
reviewed
Oct 23, 2026
mdtoguchi
left a comment
mdtoguchi
left a comment
Contributor
There was a problem hiding this comment.
Can you update the PR summary too?
bviyer
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function containerizeRawImages was not capturing the compiler options and thus the options passed by users were dropped. This patch adds CompileOpts/LinkOpts parameters to containerizeRawImage and forwards the options extracted from the input offload files at the call site.