Repository navigation
[SYCL][UR] Rebuild debug UR libraries when UR sources change - #23658
Open
VerenaBeckham wants to merge 2 commits into
Open
VerenaBeckham wants to merge 2 commits into
VerenaBeckham wants to merge 2 commits into
Conversation
On Windows, the d-suffixed debug UR libraries (e.g. ur_adapter_opencld.dll) are built by the "unified-runtimed" ExternalProject. ExternalProject steps only re-run when their stamp files are out of date, and nothing tied the build step to the UR sources. As a result, editing a file under unified-runtime/ did not rebuild the debug libraries in an incremental build, although the release libraries (built via add_subdirectory) were rebuilt. Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Clean Ninja builds can fail because ur_commond.lib is undeclared with the default static loader and INSTALL_BYPRODUCTS is unsupported on supported CMake versions 3.20–3.25.
2 open issues
What changed in this PR
This PR aims to keep Windows debug Unified Runtime libraries up to date after source changes, matching the incremental rebuild behavior of the release libraries.
Changes:
- Runs the debug external-project build on every build so it checks for source changes.
- Declares installed library byproducts and adds file dependencies so rebuilt libraries are copied into the main build directory.
| File | Description |
|---|---|
sycl/cmake/modules/BuildUnifiedRuntime.cmake |
Updates debug UR rebuild scheduling and dependencies for copying installed libraries. |
Review effort: Balanced
ldorau
requested changes
Oct 29, 2026
ldorau
left a comment
ldorau
left a comment
Contributor
There was a problem hiding this comment.
Please fix the Copilot's issues and failing CI build
Apply suggested fixes. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
I applied the suggestions. I think you need to trigger another build? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the d-suffixed debug UR libraries (e.g. ur_adapter_opencld.dll) are built by the "unified-runtimed" ExternalProject. ExternalProject steps only re-run when their stamp files are out of date, and nothing tied the build step to the UR sources. As a result, editing a file under unified-runtime/ did not rebuild the debug libraries in an incremental build, although the release libraries (built via add_subdirectory) were rebuilt.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com