MysqliStmtWrapper was not timing executes individually, but cumulatively. - #14
Open
itoolsTim wants to merge 1 commit into
Open
MysqliStmtWrapper was not timing executes individually, but cumulatively.#14itoolsTim wants to merge 1 commit into
itoolsTim wants to merge 1 commit into
Conversation
…ely. Moved $startTime into execute with microtime(). Added test for this change. All passed.
itoolsTim
requested review from
daveedis
and
a lite review from Copilot
and removed request for
Copilot
August 26, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MysqliStmtWrapper was not resetting start time between executions leading to a cumulative time being measured instead of a single execution. No documents refer to this being cumulative. Ideally callers would simply sum up single executions (as outlined for debug footer which does the totals). This also is documented as being single runs in QueryLog.php:79 and all per-query in Connection.php:119, DB.php:100, ConnectionInternals.php:1446.
Test included. All tests pass.