MysqliWrapper.php real_connect() missing try catch that would accurately query log connection issues. - #15
Open
itoolsTim wants to merge 1 commit into
Open
Conversation
…ely query log connection issues. This shape is in line with other query methods. Test included.
itoolsTim
requested review from
daveedis
and
a lite review from Copilot
and removed request for
Copilot
August 26, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
real_connect() lacked a try catch that mirrored other related methods. Due to the lack of a try catch, connection issues were not reaching query log. The fix is in line with the shape exhibited by other query methods.
Test included. All tests passed.