Skip to content

[_]: refactor/enhance error logging with request IDs - #678

Merged
jzunigax2 merged 2 commits into
mainfrom
fix/webdav-log-request-id
Sep 16, 2026
Merged

jzunigax2 merged 2 commits into
mainfrom
fix/webdav-log-request-id

Conversation

@jzunigax2

@jzunigax2 jzunigax2 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
  • Add ErrorUtils.getRequestId/withRequestId helpers to consistently extract a request ID (from requestId, xRequestId, or a nested data.requestId) and append it to log messages.
  • Wire these helpers into WebDAV startup/uncaught-exception logging, the auth and error-handling middlewares, the PUT handler's replace-fallback log, and DriveItemService's UUID/path lookup fallbacks, so request IDs are consistently surfaced for debugging.
  • Add ErrorUtils.isNotFoundError and use it to suppress noisy warnings when a lookup fails simply because the item doesn't exist (404), only logging unexpected lookup errors.
  • Switch DriveItemService from the generic logger to webdavLogger for consistency with the rest of the WebDAV module.
  • Add test coverage for the new errors.utils helpers, the PUT handler fallback logging, the errors middleware, and the drive-item service lookup logging.

@jzunigax2 jzunigax2 self-assigned this Sep 14, 2026
@jzunigax2
jzunigax2 marked this pull request as ready for review September 16, 2026 13:46
Comment thread src/services/drive/drive-item.service.ts Outdated
@sonarqubecloud

Copy link
Copy Markdown

@jzunigax2
jzunigax2 merged commit c4943e6 into main Sep 16, 2026
9 checks passed
@jzunigax2
jzunigax2 deleted the fix/webdav-log-request-id branch September 16, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants