fix: describe the windows name rule we actually apply (BR-2245) - #61
Merged
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
AlexisMora
approved these changes
Sep 10, 2026
AlexisMora
pushed a commit
that referenced
this pull request
Sep 10, 2026
* fix: describe the windows name rule we actually apply (BR-2245) * chore: ignore the tarball npm pack leaves behind * chore: bump version to 1.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message we show when an item is skipped no longer matches the rule we apply.
internxt/drive-desktop#1493 changed which names Windows can actually address: a leading
space is reachable and is now accepted, while a name ending in a dot is not and
is now rejected. The message still says names cannot start or end with spaces,
and never mentions the dot — so a user whose folder was skipped is given the
wrong reason.
Updated in en, es, fr and de. The character list is unchanged: it already
matched what we reject.
Two smaller changes ride along:
of reusing the cached 1.0.0 with different contents.
npm packleaves in the working tree, which is what makesthe submodule show up as modified without anyone touching it.