Skip to content

feat: add main mail bridge lifecycle process - #1502

Open
AlexisMora wants to merge 3 commits into
feat/mail-bridge-control-channelfrom
feat/mail-bridge-settings-implementation
Open

AlexisMora wants to merge 3 commits into
feat/mail-bridge-control-channelfrom
feat/mail-bridge-settings-implementation

Conversation

@AlexisMora

@AlexisMora AlexisMora commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What is Changed / Added

In this pull request I introduce mail bridge ipc handlers for status, activation, and shutdown, and exposes it through electron preload. It also adds the mail bridge section and connects the core mail bridge views to real lifecycle states, including startup failures and the Mail-account-required state


Why

This change connects settings view to that lifecycle through a small ipc surface, allowing users to activate and manage the local bridge

@AlexisMora
AlexisMora added this pull request to stack #1503 September 15, 2026 17:40
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e44c89c0-869c-41cd-abe6-2dabb0e1bfa8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AlexisMora
AlexisMora requested a review from xabg2 September 15, 2026 17:40
@AlexisMora AlexisMora self-assigned this Sep 15, 2026
@AlexisMora AlexisMora added the enhancement New feature or request label Sep 15, 2026
Comment on lines +38 to +40
if (status.status === 'stopped') setMailBridgeViewModel(MailBridgeModule.createInitialViewModel());
if (status.status === 'starting') setMailBridgeViewModel({ status: 'starting', error: null });
if (status.status === 'error') setMailBridgeViewModel({ status: 'error', error: status.error });

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can extract this to a separated function, using a switch and checking the status. Then, you can use it below, in onStatusChanged, as it is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants