Skip to content

[PB-6531]: e2e coverage for the skip option in name collisions - #2150

Open
terrerox wants to merge 1 commit into
feat/skip-item-option-in-name-collisionfrom
test/name-collision-skip-e2e
Open

terrerox wants to merge 1 commit into
feat/skip-item-option-in-name-collisionfrom
test/name-collision-skip-e2e

Conversation

@terrerox

Copy link
Copy Markdown
Contributor

Description

Stacked on #2039. Playwright coverage for the Skip option: single and multiple duplicates, per-item vs. "apply to all", non-conflicting files still uploading while the dialog is open, and Replace trashing the matching file.

Auth, bootstrap and Drive endpoints are mocked so the specs run without a backend. The Drive mock is an in-memory list of files that answers listings and duplicate checks per folder and records trash and bridge requests; trashing removes the item so follow-up checks see the new state. Queued uploads are asserted through the task panel (a data-test hook on the panel) rather than bridge requests, because Playwright cannot intercept the bridge's CORS preflight in Firefox.

Also extracts the login mocks from the login spec into authRouteMocks.ts so both specs share them.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

yarn playwright test test/e2e/tests/specs/DRIVE-internxt-name-collision-skip.spec.ts --project "Internxt E2E tests on chromium" with the dev server running.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 11, 2026

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a5c069
Status: ✅  Deploy successful!
Preview URL: https://84fe7883.drive-web.pages.dev
Branch Preview URL: https://test-name-collision-skip-e2e.drive-web.pages.dev

View logs

@terrerox terrerox self-assigned this Sep 11, 2026
@terrerox
terrerox added this pull request to stack #2151 September 11, 2026 05:44
Covers single and multiple duplicates, per-item and apply-to-all skipping,
non-conflicting files still uploading, and Replace trashing the matching
file, with auth, bootstrap and Drive endpoints mocked so the specs run
without a backend. Queued uploads are asserted through the task panel
because Playwright cannot intercept the bridge in Firefox.
@terrerox
terrerox force-pushed the test/name-collision-skip-e2e branch from ac46f0e to 0a5c069 Compare September 15, 2026 03:33
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant