Skip to content

[MKT-1076]:fix/redirect doesn't work for GOTZHA coupon - #2155

Open
internxt-yu wants to merge 1 commit into
masterfrom
feat/redirect-GOTZHA-coupon
Open

internxt-yu wants to merge 1 commit into
masterfrom
feat/redirect-GOTZHA-coupon

Conversation

@internxt-yu

@internxt-yu internxt-yu commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

We need to redirect a price plan of a product to a different price plans without changing the link of affiliates, and the redirect for coupon GOTZHA is not working. The problem is that the GOTZHA coupon uses promotion code 'GOTZHAOFFER' and it's in the list of bloked coupon codes for redirect, so i remove it from list of blocked coupons and move it to the allow list replacing the coupon code 'GOTZHA' (unused coupon code). With modifications in test class to allow an empty list of blocked coupons.

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

In the testing process we use CloudFlare preview link, with two parameters, planID and couponCode in the checkout page:

  1. In browser introduce the link https://f4312eca.drive-web.pages.dev/checkout?planId=price_1TRoAJFAOdcgaBMQveT6cebN&couponCode=GOTZHAOFFER and see if it redirect and change the parameter with planId=price_1UAsSAFAOdcgaBMQNF0j8UfV and with same couponCode=GOTZHAOFFER. This is the redirect of the monthly plan
  2. The same process using the link, https://f4312eca.drive-web.pages.dev/checkout?planId=price_1T1xQtFAOdcgaBMQ1r2JnHsE&couponCode=GOTZHAOFFER and see if it redirect and change the parameter to planId=price_1UAwSbFAOdcgaBMQkJhPExCz and with the same couponCode=GOTZHAOFFER. This is the redirect of the yearly plan.

Additional Notes

@internxt-yu internxt-yu self-assigned this Sep 14, 2026
@internxt-yu internxt-yu added the bug Something isn't working label Sep 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@CandelR CandelR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @internxt-yu , please avoid including in testing process section that you’ve carried out on your own machine in the testing process. Try to include something that the reviewer can test as well. You could, for example, provide a link to the Cloudflare preview URL or only specify the path with the query parms, no need to include local machine urls

@internxt-yu
internxt-yu requested a review from CandelR September 14, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants