[PB-6703]: apply sub-account branding to the password recovery pages - #100
Open
victor-ferro wants to merge 4 commits into
Open
victor-ferro wants to merge 4 commits into
victor-ferro wants to merge 4 commits into
Conversation
Deploying object-storage-web with
|
| Latest commit: |
eef9725
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a740921f.object-storage-web.pages.dev |
| Branch Preview URL: | https://feat-pb-6703-recovery-pages.object-storage-web.pages.dev |
victor-ferro
marked this pull request as draft
August 21, 2026 15:58
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
object-storage-management-web | eef9725 | Commit Preview URL Branch Preview URL |
Sep 16 2026, 01:25 PM |
victor-ferro
marked this pull request as ready for review
August 24, 2026 13:07
larryrider
approved these changes
Sep 3, 2026
…ery-pages-branding
… client-side Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018YXtN69a9D3dUBC7prMfEs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The password recovery pages fell back to Internxt branding even when the sub-account had its own logo and primary colour. The three screens of the same flow showed different identities:
/subaccount/login/subaccount/forgot-password/subaccount/reset-passwordWhy it was missing
These views were written before dynamic branding landed on
main(PB-6447). They never received thebrandingprop, and their buttons hardcoded#0071e3instead of the CSS variables the login page already used. This is not a regression — they were born this way.Changes
AuthPageSkeleton— the skeleton that lived insideSubAccountLoginPagemoves tocomponents/auth/, parameterising the only thing that differs between screens: the number of fields (inputRows). Without it, the recovery pages would show the default logo while branding loads and then swap it — exactly the wrong-brand flash the skeleton exists to prevent.SubAccountLoginPagedrops 58 lines.brandingprop —ForgotPasswordViewandResetPasswordViewaccept the optionalAuthPageBrandingprop and forward it to the layout. InResetPasswordViewit is enough to add it to the existinglayoutPropsobject, which is already spread across both of its screens.Brand colours — 4 places move from a hardcoded hex to CSS variables, using the exact same class string already used by the "Log in" button:
Those are the Send reset link, Set new password and Request a new link buttons, plus the envelope icon on the "Check your inbox" screen.
How it was tested
Against a real branded partner in the local environment (
console_hostname = localhostplus abrandingrow), not mocks:#FFD400) the button label resolves torgb(24,24,27)instead of white. The previoustext-whitewould have been unreadable;--sub-account-primary-contrasthandles it./partners/forgot-passwordand/partners/reset-passwordstill renderrgb(0,113,227)with white text. The prop is optional and thevar()fallbacks do their job.tsc,eslintandbuildall clean.Notes for the reviewer
{ logoUrl, styles: primaryColor ? styles : undefined }is now repeated in 3 pages. It could be extracted into a hook, but that would also mean touchingSubAccountLoginPage; with only 3 call sites it does not seem worth it.Stacked PR
Targets
feat/pb-6703-password-recovery(#93), notmain. It depends onAuthPageBranding(which arrives with the #92 merge) and on the recovery views themselves, which #93 creates.