When adding a record map to source control, automatically add generated classes - #995
Open
isc-pbarton wants to merge 3 commits into
Open
When adding a record map to source control, automatically add generated classes#995isc-pbarton wants to merge 3 commits into
isc-pbarton wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 49.41% 49.92% +0.51%
==========================================
Files 22 23 +1
Lines 3337 3373 +36
==========================================
+ Hits 1649 1684 +35
- Misses 1688 1689 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isc-pbarton
marked this pull request as ready for review
August 19, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #955
Adding a record map to source control adds its associated data classes to source control.
Separately, creating a record map will automatically add it to source control.
why source control the generated classes?
They are not automatically generated on compilation. Generation of the data classes is a manual step. If the data classes were not source controlled, there would need to be another manual step on deployment to another environment.
why can't we just reuse the logic in the deployment manager to find related classes?
The deployment manager has some nice logic that will find all classes required by a specific business host so they can be added to a deployment. We originally thought we could use that, and make this more generic than just record maps. But that's not a good fit for source control hooks on record maps because we can't assume a business host exists using the record map.
Testing
Unit tests, plus some manual testing on record maps:
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)