Remove dependency on %Studio.SourceControl.Change - #996
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 49.41% 49.08% -0.33%
==========================================
Files 22 21 -1
Lines 3337 3229 -108
==========================================
- Hits 1649 1585 -64
+ Misses 1688 1644 -44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| Property ActivelyCommitted As %Boolean [ InitialExpression = 0 ]; | ||
|
|
||
| /// CCR associated with this change when it was created (optional) | ||
| Property CCR As %String; |
There was a problem hiding this comment.
take the opportunity to prune fields we don't need, like CCR
| quit sc | ||
| } | ||
|
|
||
| /// Returns the uncommitted change object for <var>Filename</var>, or "" if it is not in the queue |
There was a problem hiding this comment.
i want to be further convinced that these methods were directly copied from %Studio.SourceControl.Change rather than hallucinated. write a utility that copy/pastes them from %Studio source, then diff. or merge from oddDEF like a true ObjectScript geek.
| ClassMethod GetUserProductionChanges(productionName As %String, ByRef items) | ||
| { | ||
| set sql = "SELECT InternalName, Action FROM %Studio_SourceControl.Change WHERE ChangedBy = ? AND Committed = 0 AND InternalName %STARTSWITH ?" | ||
| set sql = "SELECT InternalName, Action FROM SourceControl_Git.Change WHERE ChangedBy = ? AND Committed = 0 AND InternalName %STARTSWITH ?" |
There was a problem hiding this comment.
do we need to change SQL permissions documented required? that would probably have to be a major version upgrade.
| ## [Unreleased] | ||
|
|
||
| ### Changed | ||
| - `SourceControl.Git.Change` no longer extends `%Studio.SourceControl.Change`, which is being removed from IRIS Product in 2026.3 and shipped only with CCR (#989). Existing change data is unaffected; no upgrade action is required. |
There was a problem hiding this comment.
way too wordy. we don't need to document changes to method definitions unless they are in SourceControl.Git.API. (someday we should prob mark everything else as internal or private or whatev it is). also: don't need to mention version cutoff
2 participants
Description
Resolves #989
Testing
How has this change been tested? Have you added unit or integration tests as appropriate?
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)