Repository navigation
Bump gobl.dk.oioubl to v0.0.9 - #61
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 48 48
Lines 1994 1994
=======================================
Hits 1447 1447
Misses 467 467
Partials 80 80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pedrorfdez
approved these changes
Oct 9, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Add the missing transitive gobl.ubl checksum to support clean readonly builds.
1 open finding
What changed in this PR
Updates gobl.dk.oioubl from v0.0.6 to v0.0.9 to apply stricter OIOUBL customer-contact validation.
Changes:
- Bumps the OIOUBL addon dependency.
- Refreshes related module checksums.
| File | Summary |
|---|---|
go.sum |
Updates addon integrity hashes; the transitive gobl.ubl v0.76.0 checksum is missing. |
go.mod |
Updates the OIOUBL addon requirement to v0.0.9. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
gobl.dk.oioubl v0.0.9 makes the
dk-oioubl-v2addon reject a customer that has neither a contact person with an identity code nor an email, since OIOUBL requires a customerContactwith anID(F-INV046 / F-INV051) and such a document fails the schematron on the wire. See invopop/gobl.dk.oioubl#30. The bundle still carries v0.0.6, so the silo accepts those documents today and the failure only shows up in the sending workflow.Changes
gobl.dk.oioublfrom v0.0.6 to v0.0.9. Between them the module also moved party endpoints to the ISO 6523 participant form while still reading the earlier register spellings, and broughtgobl.ublto v0.76.0 as a transitive dependency.Next
Bump the silo to the gobl.dev release this produces, so the rule applies at build time.