Several Potential Bug Fixes - #2800
Open
owenallen-sudo wants to merge 33 commits into
Open
owenallen-sudo wants to merge 33 commits into
owenallen-sudo wants to merge 33 commits into
Conversation
Removed duplicate include of 'fs/devices.h'.
cleanup and critical bug fixes such as an integer overflow/underflow
More Bug Fixes
Removed modification note from Terminal.m file.
Merge between the 2 branches
No actual bug fixes, just bounds and consistency checks as well as error codes instead of silent failures for security reasons
Fixes for memory leaks, use after free, as well as implementation improvements such as synchronisation and more
Potentially fixed race conditions. Added null checks for tty, tty->port, client_data and len in ios_tty_write. Added a null pointer in ios_tty_cb_resize. Fixed an integer underflow in ios_tty_console_write. Added an error check in tty_alloc_driver. Added length validation to prevent zero-length operations in ios_tty_cb_send_input. Added null checks in ios_tty_write_room. Null checks for tty, data and len in ios_tty_console_write. Fix for an objective c object leak.
Fix for buffer overflow in actuate_kernel(). Fix for buffer overflow in linux_read_file(). Fix for null pointer dereference in linux_write_file(). Added error check in linux_set_hostname().
No actual bug fixes, just bounds and consistency checks as well as error codes instead of silent failures for security reasons
Fixes for memory leaks, use after free, as well as implementation improvements such as synchronisation and more
Potentially fixed race conditions. Added null checks for tty, tty->port, client_data and len in ios_tty_write. Added a null pointer in ios_tty_cb_resize. Fixed an integer underflow in ios_tty_console_write. Added an error check in tty_alloc_driver. Added length validation to prevent zero-length operations in ios_tty_cb_send_input. Added null checks in ios_tty_write_room. Null checks for tty, data and len in ios_tty_console_write. Fix for an objective c object leak.
Fix for buffer overflow in actuate_kernel(). Fix for buffer overflow in linux_read_file(). Fix for null pointer dereference in linux_write_file(). Added error check in linux_set_hostname().
Refactor Linux kernel interaction functions to improve error handling and ensure proper memory management.
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Add validation for syscall number in handle_interrupt.
DLeylandOY
approved these changes
Sep 13, 2026
RepoKan
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got several bug fixes that would likely work and would have almost no impact if they don't. The PR includes fixes for race conditions, integer overflows, buffer overflows, null pointer dereferences and more. There are also code cleanups such as the duplicate #include "fs/devices.h" in app/terminal.m removed. My fixes are in app/terminal.m, app/terminal/term.js, platform/darwin.c, asbestos/gadgets-aarch64/, app/LinuxTTY.c, app/LinuxPTY.c, platform/platform.h and more. The only downside I have found with my patches is that scrolling is briefly locked when doing clear command but that is just one of my patches. Not all of the fixes are actual bugs or cleanups, some are just fixing vulnerabilities incase there is a vulnerability in the Apple sandbox. Many however are actual bugs. I can't verify with certainty my patches work and produce no downsides though.