Repository navigation
cmake: fix othertypes.h not getting installed - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya! I've been recently trying to package libweaver/si-edit & isle-portable on Gentoo, however I noticed what is (most likely?) a small typo in the CMakeLists file. I reasonably decided to seperate away building libweaver and isle-portable into 2 seperate packages, and then just dynamically linking the former instead of building it in-tree, however it seems like the
othertypes.hheader is not getting installed to /usr/include/libweaver which causes problems.In my package I just patched the cmake file in libweaver to copy that header and it fixed the issue, so unless there's some good reason behind this I don't know about, I assume that it's probably just a mistake that got overlooked.