Repository navigation
Remove the Node.js implementation and its tooling - #36
Merged
Merged
Conversation
The action runs install.sh as a composite action, so the Node sources, the bundle, npm files and the old-vs-new parity test are no longer used. - Delete src/, build/, package.json, package-lock.json and test/parity.sh. - build.yml: run shellcheck instead of npm lint/build. - Rename parity.yml to unit.yml, keeping the unit and windows-zip jobs. - codeql.yml: analyze the actions language with codeql-action v4.38.3, drop autobuild and the now-unneeded codeql-config.yml. - dependabot.yml: track github-actions instead of npm. - DEVELOPMENT.md: describe the Bash workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
download() already bounds its curl call, but the GitHub API request did not, so a stalled connection hung the step until the job timeout. Node's fetch gave up after 300 s; match that with --max-time 300 and a 10 s connect timeout. Only affects runs where version is empty or latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
azwolski
approved these changes
Oct 9, 2026
| ```bash | ||
| export RUNNER_TEMP=/tmp/runner_temp | ||
| npm run run | ||
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_VERSION=1.23.0 bash install.sh |
Collaborator
There was a problem hiding this comment.
Suggested change
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_VERSION=1.23.0 bash install.sh | |
| touch /tmp/p | |
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_VERSION=1.23.0 bash install.sh |
|
|
||
| ```bash | ||
| INPUT_PLATFORM=macOS INPUT_VERSION=1.23.0 INPUT_ARCHITECTURE=x86_64 npm run run | ||
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_PLATFORM=macOS INPUT_VERSION=1.23.0 INPUT_ARCHITECTURE=x86_64 bash install.sh |
Collaborator
There was a problem hiding this comment.
Suggested change
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_PLATFORM=macOS INPUT_VERSION=1.23.0 INPUT_ARCHITECTURE=x86_64 bash install.sh | |
| touch /tmp/p | |
| RUNNER_TEMP=/tmp/rt GITHUB_PATH=/tmp/p INPUT_PLATFORM=macOS INPUT_VERSION=1.23.0 INPUT_ARCHITECTURE=x86_64 bash install.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35. The action now runs
install.shas a composite action, so this removes the Node implementation and the tooling around it.Changes
src/,build/,package.json,package-lock.json,node_modulesfrom.gitignore, andtest/parity.sh(old-vs-new differential test).build.yml: replace npm lint/build/diff withshellcheck install.sh test/*.sh. Job namebuildis unchanged.parity.yml→unit.yml: keep theunitandwindows-zipself-tests; drop theparityjob and thelintjob (now inbuild.yml).codeql.yml: languagejavascript→actions, bumpinit/analyzefrom v3.25.12 to v4.38.3 (pinned SHA), remove autobuild andcodeql-config.yml(it only ignoredbuild/andnode_modules/).dependabot.yml: ecosystemnpm→github-actions.DEVELOPMENT.md: replace Node instructions with the Bash workflow.install.sh: add--connect-timeout 10 --max-time 300to the latest-version API request. Without it a stalledapi.github.comconnection hung the step until the job timeout; Node's fetch gave up after 300 s. Only affectsversionempty orlatest.README.md,action.ymland theinterface/e2e tests intest.ymlare unchanged. The@v1-nodetag remains available as a fallback.Testing
bash test/unit.sh: 81 passed locally;python3 test/download-timeout.py: OK.actionsanalysis initializes and completes.🤖 Generated with Claude Code