Repository navigation
fix(problem): initialize Knapsack and ZDT5 bit storage - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knapsack and ZDT5 generate random bits but write them into copies returned by
BinarySolution.variables, leaving the stored bits false. Assign the sampled vectors through the existing setters so returned solutions contain the generated values, preserving the existing random sources and sampling calls.Add six parameterized regression cases covering stored values through both RNG paths, the ZDT5
< 0.5threshold, and zero-item Knapsack. The latter now returns an empty vector instead of raisingIndexError. Record the correction under Unreleased in the changelog.Validation on Python 3.12.15:
make lintpasses.make test: 1,119 passed.