Repository navigation
Allow overriding the automatic screw bin size - #20
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
The screw entry tab now has Width and Depth fields for the bin size. They show the size computed from the screw until you edit one; the Auto button returns to the computed size. The override applies to every screw in a comma-separated list and to insert-only mode (width only), and editing a queued screw restores its stored size.
When the chosen width is too narrow for the screw to lie flat across the top opening at the stacking lip, a non-blocking hint says the screw will sit tilted. The fit test is the new engine function
screwLiesFlatinscrewListImport.ts, which shares the overall-length calculation withscrewBinWidthUnitsbut leaves out the handling clearance. An M3x30 socket head cap screw therefore fits a 1 unit bin without a hint, while an M3x40 shows it.Tests: 8 new
screwLiesFlatcases (issue case, boundary at the 36.3 mm opening, overall vs nominal length, lengthless fasteners).npm run buildandnpm testpass (1429 tests).