Model.objects.all() does not convert types in primary keys #147

Activity

1. jacebrowning

   added

   bugSomething isn't workingSomething isn't working

   on Dec 26, 2019
2. jacebrowning

   added

   help wantedExtra attention is neededExtra attention is needed

   on Apr 13, 2020
3. nielslerches commented on Sep 19, 2022

   

   nielslerches

   on Sep 19, 2022

   More actions

   Hi,

   Is this issue still relevant?

   If so, I'd like to take a crack at solving the issue, as I have a potential use case for this feature.
4. jacebrowning commented on Sep 19, 2022

   

   jacebrowning

   on Sep 19, 2022

   OwnerAuthor

   More actions

   @nielslerches yes, it's still an issue. You can confirm that by removing the xfail marker to see the test fail.

   Let me know if you have any more questions!
5. nielslerches

   added a commit that references this issue on Sep 20, 2022

   jacebrowning#147 Convert types in primary key fields

   ed3522a
6. Yuren0312 commented on Oct 18, 2026

   

   Yuren0312

   on Oct 18, 2026

   More actions

   I can confirm this is still an issue on current main — Model.objects.all() extracts path fields (like the primary key) from the filename as strings, and because those fields aren't stored in the file contents, they never pass through the field's converter in Mapper.load() (which deliberately excludes pattern fields).

   I've opened #501 with a fix: all() now coerces the path-derived values to their declared types via the existing map_type() machinery before calling get(). I also removed the xfail marker on test_values_are_filled_from_disk, which now passes.

   Verification: pytest tests/ is 128 passed / 1 skipped / 4 xfailed (remaining xfails are unrelated pre-existing issues), and mypy/black/isort/pylint/pydocstyle all pass. Happy to adjust if you'd prefer a different approach.