iOS agent-loop: Send, presets, hardware keys, voice, custom slash - #112
Conversation
|
@codex review |
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e46fc9e9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Tap Send writes CR into the PTY. Long-press writes a newline without submitting. The IME mapping treats Send as an honest newline because UITextDocumentProxy cannot submit to a remote agent. Closes #85
Agent is the default ten-key row. Confirm types y/n/a/1/2/3 and can submit. The choice lives in the App Group so the SSH accessory and the extension stay in sync. Closes #84
pressesBegan plus UIKeyCommand use a shared table. Cmd+C is not 0x03. Closes #83
Tap mic to start and stop. Long-press cancels and inserts nothing. The keyboard extension does not show a mic and does not import Speech. Closes #82
/foo added in Settings appears in the panel. A built-in duplicate is rejected. Inserts stay plain text. Closes #86
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a46dc4f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Set a recording session before the engine starts. Stopping the mic waits for the final recognition result instead of cancelling it. Leaving the terminal cancels capture. Send consumes armed Ctrl.
1 participant
Depends on #111 (first commit). Closes #85. Closes #84. Closes #83. Closes #82. Closes #86.
Send (#85)
Tap Send in the SSH extra row writes CR. Long-press writes LF. The IME mapping treats Send as an honest newline.
Presets (#84)
Agent is the default ten-key row. Confirm types y/n/a/1/2/3 plus Send and Esc. Stored in
group.com.keyjawn.Hardware keys (#83)
pressesBegan+UIKeyCommanduseHardwareKeyMapping. Esc, Tab, arrows, Ctrl+C/D/Z reach the PTY. Cmd+C is not0x03.Voice (#82)
Main-app
SFSpeechRecognizeron the terminal Mic key. Commit writes UTF-8. Cancel inserts nothing. The extension row has no mic and does not import Speech.Custom slash (#86)
Settings adds
/footo App Group JSON. The panel shows it./compactis rejected. Inserts stay plain text.Tests
Local
KeyJawnKitTests164 passed twice on iPhone 17 Pro.