Skip to content

Clarify the iOS remote-only boundary for App Review - #116

Merged
jamditis merged 2 commits into
mainfrom
release/ios-v1.0-app-review-remediation
Aug 31, 2026
Merged

jamditis merged 2 commits into
mainfrom
release/ios-v1.0-app-review-remediation

Conversation

@jamditis

Copy link
Copy Markdown
Owner

Summary

  • Remove the session-free preview path and make the remote SSH execution boundary explicit in the app, keyboard, review notes, and public copy.
  • Route SSH and copied-image SFTP through the native iOS network path, with optional TLS tunneling, host-key checks, bounded cancellation, and user-safe errors.
  • Correct the iPad keyboard assistant-row spacing, add swipe-down secondary characters, and apply one shared visual theme to onboarding, hosts, settings, terminal controls, and App Store screenshots.
  • Add App Review boundary, transport, keyboard, privacy-manifest, and installed-keyboard tests.
  • Tighten store authentication, unsubscribe handling, request enumeration defenses, email accounting, and failure behavior.
  • Update the website, social guidance, release evidence, and deployment action pins without publishing the site from this branch.

Why

Apple rejected the earlier build because the local execution and file-access boundaries were unclear. This change makes the app's remote-only behavior visible, testable, and consistent across runtime code, review metadata, screenshots, and public documentation.

Verification

  • iPhone 17 Pro, iOS 26.5: 245 tests, 244 passed, one expected live-network skip, zero failed.
  • iPad Pro 13-inch, iOS 26.5: 245 tests, 244 passed, one expected live-network skip, zero failed.
  • Xcode static analysis: passed.
  • Xcode project regeneration: byte-identical.
  • New Swift-file format check: passed.
  • Worker: 162 passed, 12 expected environment skips.
  • Store: 35 passed.
  • App Store helper: one passed.
  • Website production build: 10 routes built.
  • Staged secret scan: no token, private-key, JWT, AWS-key, Slack-token, or public reviewer-hostname finding.
  • git diff --check: passed.

No Android source changed. This Mac has no Android SDK, so the Android unit and lint matrix is left to GitHub Actions.

Release state

App Store version 1.0 build 9 is valid, selected, and waiting for review. Release type is manual. This pull request does not release the app, publish the website, create a tag, or merge into main.

Apple rejected the earlier build because its local execution and file-access boundaries were unclear. Preserve reviewer confidence by removing the preview surface, using the native iOS network path, tightening release and store safeguards, and keeping the evidence and tests with the code.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-31T18:46:26.465604Z 198cedc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

GitHub's iPad runner can ignore swipe-to-delete in the Settings split view, leaving the keyboard installed after the product assertions pass. Use the explicit edit controls and restore normal mode so the UI tests return Settings to its original state.
@jamditis
jamditis merged commit de79a6b into main Aug 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant