Repository navigation
feat: look up hooks by tag - #231
Merged
Merged
Conversation
Hooks can carry a string array of tags. getHooksByTag finds hooks by one tag or any of several, and getTaggedHooks returns a map of every tag to its hooks. Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 434 475 +41
Branches 110 122 +12
=========================================
+ Hits 434 475 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaredwray
marked this pull request as ready for review
October 21, 2026 23:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature. Hooks can be tagged with a string array and looked up across events.
Summary
IHook.tagsis an optionalstring[].Hook,WaterfallHook, andParallelHookaccept it as an optional fourth constructor argument.TypeErrorand the hook is not stored.getHooksByTag(tag | tags)returns hooks that have any of the given tags, in storage order.getTaggedHooks()returns aMapof every tag to the hooks that have it.Test plan
tags,getHooksByTag, andgetTaggedHooks