Conversation
xvorient.c: get_exif_orientation()'s buf/bufsize parameters are used in the #else (HAVE_EXIF) branch but not in the #ifndef HAVE_EXIF fallback that just returns ORIENT_NONE. Mark them explicitly unused in that branch with (void) casts, to avoid compiler warning. xvpds.c: the strncat(inote, tmptmp, INOTESIZE - strlen(inote) - 1) call is fine at runtime, but GCC can't prove it so will warn about it. Switched to snprintf-based concatenation, which has well-defined truncation semantics GCC can verify. Also added an explicit guard against inote_len reaching INOTESIZE (which would otherwise underflow the computed size argument).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two compiler warnings.
xvorient.c: -Wunused-parameter warning: get_exif_orientation()'s buf/bufsize parameters are used in the #else (HAVE_EXIF) branch but not in the #ifndef HAVE_EXIF fallback that just returns ORIENT_NONE. Mark them explicitly unused in that branch with (void) casts, to avoid compiler warning.
xvpds.c: -Wstringop-truncation warning: the strncat(inote, tmptmp, INOTESIZE - strlen(inote) - 1) call is fine at runtime, but GCC can't prove it so will warn about it. Switched to snprintf-based concatenation, which has well-defined truncation semantics GCC can verify. Also added an explicit guard against inote_len reaching INOTESIZE (which would otherwise underflow the computed size argument).