Repository navigation
Configurable listen backlog - #263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I built a small server using
runServerand benchmarked it under concurrent load.It had a severe throughput degradation at around 16 simultaneous clients.
I traced it down to the backlog setting that
makeListenSockethard-codes to5. This setting forces the kernel to drop connections if there are already 5 pending in the queue. The client then goes into TCP retransmit instead of completing a handshake.In my benchmark, bumping the backlog moderately improved performance for up to 16 clients, and doubled it past 16.
The added parameter to
makeListenSocketmade it takeInt -> Int, which I assumed you would find objectionable. So, since this is a breaking change already, I took the liberty to migrate to the more descriptiveHostNameandPortNumber. 🙂I also bumped the version and added changelog entries, and prepared the commits such that they don't need squashing before merging.