fix: execute example module tests via surefire + junit-jupiter-engine - #297
Merged
AndreasIgel merged 1 commit intoSep 22, 2026
Merged
Conversation
Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
devin-ai-integration Bot
added a commit
to igel-devin-ai/simple-builders-devin-fork
that referenced
this pull request
Sep 25, 2026
- branch predated java-helpers#297 and its pom revert dropped the merged surefire / junit-jupiter-engine setup; pom restored to upstream so the example tests keep running - javadoc: state explicitly that @SimpleBuilderFor is not @inherited Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
examplemodule declared test sources but never executed them:mvn testran 0 tests because the module only depended onjunit-jupiter(the API artifact) and had no Surefire plugin configured.junit-jupiter-enginetest dependency so JUnit Platform has a discoverable enginemaven-surefire-plugin(${plugin.maven.surefire.version}= 3.6.0) for the moduleAfter this change
mvn -pl example testexecutes all 6 test classes (28+ assertions, 0 failures).Split out of #296 per review feedback.