Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset.transpose()currently skips every column whose header matches the first header. Only the first column belongs in the new header row; later columns with the same name must still become data rows.Skip the first column by position. Add regression tests for a repeated first header and for the case where an original cell value matches the first header, causing data loss after two transposes.
This addresses the remaining case reported by punchagan in #199 (comment). The earlier PR #199 is already merged; this is a follow-up fix.
Validation:
TZ=UTC, without skipped tests.git diff --checkpasses.AI assistance: OpenAI Codex assisted with the implementation, regression tests, and this PR description.