Conversation
cucuwang
marked this pull request as ready for review
September 9, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that
Dataset.subset()selects rows by zero-based position and columns by header value. Document ordering and return behavior, and add executable examples to the API docstring and tutorial. Runtime behavior is unchanged.Refs #366. Column-position selection is outside this documentation change.
Validation: 183 baseline tests passed with
TZ=UTC; the focused subset test, nine example checks, and applicable pre-commit hooks passed. The HTML build completed with the same 11 diagnostics as the unchanged baseline, with no new diagnostics. An AST comparison confirmed executable code is unchanged.AI assistance: OpenAI Codex with GPT-6 Astra (xhigh) for scope and architecture, GPT-5.6 Luna (max) for implementation, and final integration review and validation in Codex.