Repository navigation
Add a tutorial for a small-buffer-optimized owning wide pointer - #465
Merged
Merged
Conversation
jbcoe
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 11 11
Lines 836 836
Branches 41 41
=======================================
Hits 782 782
Misses 26 26
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
6 times, most recently
from
October 7, 2026 07:43
e18f891 to
b22eac2
Compare
jbcoe
marked this pull request as ready for review
October 7, 2026 22:05
philipcraig
requested changes
Oct 8, 2026
philipcraig
left a comment
philipcraig
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes for two things: the inactive-union-member access at line 116 (and 110), and tests for the two assignment operators. The other notes are suggestions.
jbcoe
marked this pull request as draft
October 8, 2026 22:15
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
3 times, most recently
from
October 9, 2026 13:01
de2d175 to
e34c32f
Compare
jbcoe
marked this pull request as ready for review
October 9, 2026 13:54
jbcoe
marked this pull request as draft
October 9, 2026 13:55
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
5 times, most recently
from
October 9, 2026 17:02
1e6509b to
54f3685
Compare
Owner
Author
|
I'm not worried about code coverage results for tutorial code. |
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
from
October 9, 2026 17:17
54f3685 to
cf702dd
Compare
Owner
Author
|
@RyanJK5 once this tutorial PR looks ok, did you want to try adding SBO support to |
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
from
October 9, 2026 17:24
cf702dd to
6df5cc7
Compare
jbcoe
marked this pull request as ready for review
October 9, 2026 17:25
Collaborator
Happy to! |
RyanJK5
approved these changes
Oct 9, 2026
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
3 times, most recently
from
October 10, 2026 08:12
42f8db5 to
bb531ae
Compare
jbcoe
requested review from
RyanJK5 and
philipcraig
and removed request for
philipcraig
October 10, 2026 08:16
philipcraig
approved these changes
Oct 10, 2026
philipcraig
left a comment
philipcraig
left a comment
Collaborator
There was a problem hiding this comment.
Both earlier points are fixed. Two suggestions below.
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
from
October 10, 2026 09:58
bb531ae to
76fe976
Compare
Wide pointer SBO initial pass Fix object lifetime bugs in the SBO wide pointer tutorial Free indirect storage on destroy. Leave a moved-from buffer object in place for its owner to destroy, and destroy moved-from objects in swap before reusing their storage. Constrain the forwarding constructor and use the decayed type. Static assert that the type fits the buffer. Initialise CountOps::ops_ and copy it in the copy constructor. Address review of the SBO wide pointer tutorial Select storage with BufferStorage/IndirectStorage tag types so buffer requirements apply only to buffer storage, and make the constructors explicit. Use std::launder for buffer access and static_cast from void*. Make swap noexcept and drop redundant self-checks and defaulted members. Add missing includes and brief prose. Rename the target to wide_pointer_sbo_tutorial and drop unused Bazel dependencies. Raise coverage of the SBO wide pointer tutorial Add tests that copy an indirect pointer, copy and move an empty pointer, and check a copied buffer object is destroyed. Ignore tutorials in Codecov, as for the other test files. Reduce clang-tidy suppressions Consolidate and simplify tests Add missing include Use std::size_t Add tutorial for a SBO-optimized wide pointer Wide pointer narrowing Check storage kind and copy count in copy-assignment tests Start the buffer's lifetime in the buffer-storage constructor Disable clang-tidy for the SBO wide pointer tutorial Use placement new to activate the buffer and re-enable clang-tidy Simplify the SBO tutorial's moved-from comment Tidy the SBO tutorial and check the target of move-assignment Use std::construct_at to activate the buffer Give the SBO wide pointer's copy-assignment the strong guarantee
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
from
October 10, 2026 10:00
209e4e7 to
b71fe3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.