Repository navigation
Wide pointer narrowing tutorial using inheritance - #466
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 11 11
Lines 836 836
Branches 41 41
=======================================
Hits 782 782
Misses 26 26
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
13 times, most recently
from
October 10, 2026 08:12
42f8db5 to
bb531ae
Compare
jbcoe
force-pushed
the
wide-pointer-narrowing
branch
7 times, most recently
from
October 10, 2026 09:57
aab0990 to
419f215
Compare
jbcoe
force-pushed
the
jbcoe-wide-pointer-sbo
branch
2 times, most recently
from
October 10, 2026 10:00
209e4e7 to
b71fe3c
Compare
jbcoe
force-pushed
the
wide-pointer-narrowing
branch
from
October 10, 2026 10:06
419f215 to
4ecaad5
Compare
jbcoe
marked this pull request as ready for review
October 10, 2026 10:09
philipcraig
reviewed
Oct 10, 2026
philipcraig
left a comment
philipcraig
left a comment
Collaborator
There was a problem hiding this comment.
Nice small demonstration of narrowing through vtable inheritance. The main point is the unconstrained T* constructors, which accept &wptr and bring back the nested call the tutorial is about. The rest are clarity suggestions.
jbcoe
force-pushed
the
wide-pointer-narrowing
branch
2 times, most recently
from
October 10, 2026 17:17
c2481f8 to
fd07ed3
Compare
FOLD Build the wide pointer narrowing tutorial with CMake and rename its Bazel target Use Vtable capitalisation in the narrowing tutorial Fix clang-tidy findings in the narrowing tutorial Lower-case wide vtable in the narrowing tutorial comment Name the narrowing tutorial's thunk parameter self Narrow wide pointers with conversion operators on WidePtr
jbcoe
force-pushed
the
wide-pointer-narrowing
branch
from
October 10, 2026 19:24
fd07ed3 to
9d40e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.