Repository navigation
Tidy up the layout follow-ups to the xyz/ move - #474
Closed
philipcraig wants to merge 3 commits into
Closed
philipcraig wants to merge 3 commits into
philipcraig wants to merge 3 commits into
Conversation
- Put the detail headers in a :detail Bazel target that the tests depend on directly, rather than private headers of :protocol. - Find the coverage script's headers with one recursive glob under xyz/ and create each destination directory as files are copied, so any translation unit can be probed. - Move consteval_check.h, shared by tests and tutorials, to xyz/testing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
+ Coverage 93.54% 94.95% +1.41%
==========================================
Files 11 9 -2
Lines 836 793 -43
Branches 41 25 -16
==========================================
- Hits 782 753 -29
Misses 26 26
+ Partials 28 14 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
philipcraig
marked this pull request as ready for review
October 11, 2026 07:24
The tutorials include only consteval_check.h; .bazelrc already enables -freflection for every target.
Owner
|
Feel free to merge directly into #469 I don’t think that we gain much by splitting things apart here. |
Collaborator
Author
|
Folded into #469 at jbcoe's request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #469; carries its commit until it lands.
:detailBazel target that the tests depend on directly.xyz/and create each destination directory as files are copied, so any translation unit can be probed.consteval_check.h, shared by tests and tutorials, toxyz/testing.//:protocolBazel dependency.Closes #470.
Closes #471.
Closes #472.
Closes #473.