Repository navigation
Build the site on jg-personal-astro-ui 0.3.1 without the client router - #12
Merged
Merged
Conversation
… router The layout, header, footer, theme, progress bar, sections, cards, buttons, badges, table, segmented controls, copy buttons, code windows, and the Agentic Coding mark come from jg-personal-astro-ui, and the site's own copies are gone. Pages load as ordinary documents, the always-dark panels use the package's inverse surface, and assets:generate writes the favicon and the open-graph mark from the package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jesus Graterol <jesusgraterol.dev@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds Agentic Coding on
jg-personal-astro-ui0.3.1, so it shares its UI with the other jg sites, and drops Astro's client router.Frame
og:type articleand itsarticle:*tags on articles) and its theme script.Pages
jg-executetoggles.prose, and refine's warning is acallout.InstallCommand, named "Copy install command".No client router. Pages load as ordinary documents. The package's cross-document view transitions, speculation rules, and progress bar replace
ClientRouter.Removed:
global.css, which is now the package's importsTokens:
chart-3→accent,error→danger,section-title-long→section-title.Assets:
assets:generatewritesfavicon.svgfrom the package's mark and draws it into the open-graph image. The image renders identically.Why 0.3.1: moving here showed that 0.3.0's copy button widened when "Copy" became "Copied". The package fixed that in 0.3.1, which this site uses.
Tests
aria-current, the menu label is "Navigation menu", and the token checks read--jg-*.Two contrast failures that axe found during the move are fixed:
verify-build.tsdropsog:image:secure_urland lets the breadcrumb carry a class.Docs: the README,
project.md(navigation, copying, theme, navigation between pages, tokens, typography, the tree, and the tests), anddocs/asset-attribution.md.npm run checkpasses: 43 unit, typecheck, lint, format, the build with its verification, 23 integration, and 58 end-to-end tests with axe in both themes.npm auditreports advisories in existing dev tooling (@vitest/mocker,brace-expansion,fast-uri); this PR leaves them alone.🤖 Generated with Claude Code