Repository navigation
Harden S3_PING remove() and removeAll() error handling - #663
Merged
Merged
Conversation
rhusar
commented
Oct 8, 2026
rhusar
commented
Member
- remove(): log with String.format including the failed key instead of relying on a JGroups message bundle key
- removeAll(): catch Throwable in the outer block so an Error does not escape into the view change; keep stack traces of per-object delete failures; fix misleading trace messages
- Tests: assert on S3 invocations and logged errors, cover Error during listing, per-object delete failures and remove(); handle Object methods in the client proxy
- remove(): log with String.format including the failed key instead of relying on a JGroups message bundle key - removeAll(): catch Throwable in the outer block so an Error does not escape into the view change; keep stack traces of per-object delete failures; fix misleading trace messages - Tests: assert on S3 invocations and logged errors, cover Error during listing, per-object delete failures and remove(); handle Object methods in the client proxy Signed-off-by: Radoslav Husar <rhusar@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.