Repository navigation
[#577] Isolate S3_PING discovery tests from each other - #667
Merged
Merged
Conversation
A failing discovery test leaked its channels and the bucket prefix system property into the following tests, which shared the same cluster name, cascading a single failure into further failures. - always close channels and clear the bucket prefix property on failure - use a random cluster name per test - wait for all channels to converge on the same view instead of a fixed sleep Signed-off-by: Radoslav Husar <rhusar@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failing discovery test leaked its channels and the bucket prefix system property into the following tests, which shared the same cluster name, cascading a single failure into further failures.