Conversation
lennney
marked this pull request as ready for review
August 2, 2026 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This project imports
searchandSafeSearchTypefromduck-duck-scrape.ddg-kitmaintains those exports in its frozen Web compatibility surface.The npm alias keeps the current source import unchanged. Version
0.1.1adds the CommonJS declarations required by this project's Node16 TypeScript configuration.I maintain
ddg-kitand disclose that relationship here. The package is an unofficial greenfield compatibility implementation. It has no affiliation with DuckDuckGo or the originalduck-duck-scrapemaintainers.Maintenance and adoption evidence
ddg-kit.v0.1.1fixed the Node16 CommonJS declaration gap found during this downstream test. The release adds a packed regression fixture for the exact failure.ddg-kitruns packed consumer checks on Node 18.17, 20.20, and 22.23. The release uses npm provenance and passes package-shape checks for CommonJS, ESM, and bundler consumers.These checks support the frozen Web and News package contract. They do not provide a DuckDuckGo service-level guarantee.
Changes
duck-duck-scrapetoddg-kit@0.1.1Validation
npm ci --ignore-scripts --no-audit --no-fundnpm ls duck-duck-scrape --depth=0npx jest src/__tests__/duck-search-compat.test.ts --runInBandnpx eslint src/__tests__/duck-search-compat.test.tsnpm run buildThe commands above pass with the published package. Full lint reports 46 errors in unchanged files. Full Jest also has existing failures in server, tool, agent, and Docker suites. The new test and production TypeScript build pass.
Rollback
This change has no data migration. A rollback only needs the previous dependency specifier and lockfile entries.