Repository navigation
fix(webhook-destination): honor JITSU_TABLE_NAME in batch mode - #1632
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
The batch path chose the bulker table from event.event || event.type and sent the whole event, so a JITSU_TABLE_NAME override was ignored and leaked into the payload. Use it as the table name when present and strip it from the body, as the bulker destination does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1628
In batch mode the webhook destination picked the bulker table from
event.event || event.typeand posted the whole event as the body. TheJITSU_TABLE_NAMEoverride (whichbulker-destination.tshonors and removes from the payload) was ignored, so every distinct event name opened its own Kafka topic, and the override field leaked into the stored payload.The batch path now uses
event[TableNameParameter]when present, falling back toevent.event || event.typeas before, and omits the field from the body.Test: a new
webhook-batch-table-name.test.tsruns the destination in batch mode against a mocked bulker endpoint and asserts thetableNamequery parameter and the body. The override case failed before the change (expected 'button_clicked' to be 'my_table') and passes after; the default case is unchanged. The existing webhook-destination tests still pass. Run with vitest in the destination-functions package; prettier check clean.AI assistance was used to prepare this change and its validation.