fix: pair embedding vocabulary with heterogeneous dataset axes - #35
Draft
jkobject wants to merge 2 commits into
Draft
fix: pair embedding vocabulary with heterogeneous dataset axes#35jkobject wants to merge 2 commits into
jkobject wants to merge 2 commits into
Conversation
Owner
Author
Downstream pairingConsumed by cantinilab/scPRINT-2#17. That PR restores Targeted validation at this head: 5 mapping/sampler tests, Ruff, py_compile and diff-check. The historical broad |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 48.84% 53.18% +4.33%
==========================================
Files 10 10
Lines 1984 2044 +60
==========================================
+ Hits 969 1087 +118
+ Misses 1015 957 -58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scPRINT historically exposed
data.gene_embeddingsand paired it incli.pytomodel.precpt_gene_emb. The parameter was moved model-side in 2025, but multi-species artifacts have heterogeneous native VAR axes; merely filtering model embeddings after DataModule construction does not preserve a shared positional mapping.Changes
gene_embeddingsas an explicit DataModule source for the model vocabulary_store_idxwhile retaining_storage_idxcompatibilitygenes_dictpreserve the embedding-subset order used by the modelValidation
The broader historical
tests/test_base.pyinvocation exceeded the bounded local runtime and is not claimed green here. The scPRINT-2 PR will pin the immutable reviewed SHA for the distributed smoke.Downstream
Required by cantinilab/scPRINT-2#17.