Repository navigation
Make the kernels native optional, so a binary using lev starts without them - #10
Merged
Merged
Conversation
…t them A program that links lev and builds for Windows, where no kernels are declared, got a binary that refused to start: jolt took the spec with no archive for the platform as a required runtime library and looked for lev_kernels.dll. Optional, it starts, and lev.tensors/available? is false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newsroom's v0.14.0 Windows binary refused to start:
("lev_kernels.dll" "The specified module could not be found"). The kernels spec declares archives for darwin and linux only, so on Windowsjolt buildencodes it as a required runtime library, falls back to its conventional name, and the load is fatal at startup. Interpreted runs skip the check, which is why Windows CI passed.:optional truemakes it a guarded load, as BLAS already is: the binary starts,lev.tensors/available?is false, andtinydecide/load-releaserefuses with:model-unavailable. On macOS and Linux the archive is still linked statically.Checked on linux: a
jolt buildbinary against this branch links the kernels and answers as before; tinydecide-test 211 assertions pass.