Repository navigation
Fix the release build - #5
Merged
Merged
Conversation
jolt build links the archives into a shared object, and GNU ld refuses llama-common's non-PIC objects there. It also links every :static archive, optional or not, so a tree without jolt mlx (CI, linux) failed on the missing liblev_mlx.a; an empty archive stands in and lev.mlx reports itself unavailable.
deps.edn links QuartzCore on mac, and only build_mlx.sh made its stub, so a tree without jolt mlx failed the binary's link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.0 release build failed on both platforms; no binary was built since v0.2.0, so these went unnoticed.
With these the mac release build passes (run 38472730534). Linux still fails while jolt preloads the archives (undefined C++ typeinfo symbol); that's jolt-lang/jolt#1343 and needs a jolt release.